RT-754: Remove assert from development builds #5221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
requested changes
Feb 18, 2023
There was a problem hiding this comment.
This will be handled by removing the assert statements as well changing this script to always run these rules in CI 6db0194. This way we can still build and test with console.assert added in local builds.
Please close or include the webpack config changes here first.
3 tasks
robwalch
added a commit
that referenced
this pull request
Feb 27, 2023
* Implement ErrorController … Add Error Handling Integration Tests Handle missed probe transmux probe with with FRAG_PARSING_ERROR Handle encrypted init segment and subtitle decryption failure with FRAG_DECRYPT_ERROR Remove delay when retrying after timeout Trigger FRAG_LOADING after request is made ERROR event data type must include an error property Add stats to network loader error callbacks to allow error handling to use request timing Remove use of console.warn from mp4-tools Add missing TypeScript type exports * Remove console.assert statements Resolves #5218 Closes #5221 * Remove unused frag buffered monitor * Add Load Policies and deprecate frag/level/manifest timeout and retry config options * Switch on FRAG_PARSING_ERROR or continue trying fragLoadPolicy.default.errorRetry.maxNumRetry (6) times Fixes #5011 * Switch on FRAG_PARSING_ERROR or continue trying fragLoadPolicy.default.errorRetry.maxNumRetry (6) times 2/2 Fixes #5011 * Do not reload level after calling stopLoad() and startLoad() Warn on currentFrag context reference change and use currentFrag to maintain correct stats ref Fixes #5230 * Implement ErrorActions and Pathway Switching * Fix part timeout handling Cleanup frag stats handoff * Update retry rules to require http status or timeout error (deprioritizes retry on parse errors) * Retry audio and subtitle playlist loading after failure on level switch when no alternate is available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Remove console.assert from production & development webpack builds
Why is this Pull Request needed?
r.assert error messages in production build in react app deploy
Are there any points in the code the reviewer needs to double check?
Resolves issues:
#5218
Checklist