Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support QUERYPARAM Variable Substitution #5265

Merged
merged 3 commits into from Mar 1, 2023
Merged

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Feb 27, 2023

This PR will...

Implement EXT-X-DEFINE QUERYPARAM support

Why is this Pull Request needed?

The EXT-X-DEFINE QUERYPARAM attribute is a new HLS feature that allows the definition of HLS variables based on URL search parameter key value pairs. A URL param from the playlist's parent URL can used as a variable to substitute variable declarations ({$var-name}) inside URI strings and quoted string attributes anywhere in an HLS playlist following the variable definition, just like variables defined by the EXT-X-DEFINE NAME/VALUE or IMPORT attribute(s) (#5161).

Resolves issues:

Resolves #5240

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)

@robwalch robwalch added this to the 1.4.0 milestone Feb 27, 2023
@robwalch robwalch merged commit 86d3681 into master Mar 1, 2023
@robwalch robwalch deleted the feature/define-queryparam branch March 1, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable Substitution with QUERYPARAM
1 participant