More rollup PR tweaks #5340
Merged
More rollup PR tweaks #5340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjenkinson
force-pushed
the
task/rollup-esm-and-worker-tj
branch
from
5682664
to
c23df80
Compare
|
Ah just noticed the output is written from rollup when in watch mode. There may be another way of preventing the output with a plugin checking... |
|
Ok for watch karma does actually read the files back from disk, so I just made it a directory in the gitiginore |
robwalch
approved these changes
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Remove the temporary output name for karma because the karma rollup plugin shouldn't be writing anything to disc. It seems fine locally but maybe I'm missing something?
And then remove the need for the wrapping function for the worker build by just replacing the
__IN_WORKER__var