Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not jump start gaps when paused #5502

Merged
merged 1 commit into from May 26, 2023
Merged

Conversation

robwalch
Copy link
Collaborator

This PR will...

Prevent gap-controller from jumping start gaps when paused

Why is this Pull Request needed?

So that small backward seeks can be performed along segment boundaries whose buffered content does not match playlist times can be performed without seeking forward to buffered start.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Resolves #5499

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.5.0 milestone May 24, 2023
@robwalch robwalch merged commit 75d9d2d into master May 26, 2023
15 of 16 checks passed
@robwalch robwalch deleted the bugfix/seek-back-while-paused branch May 26, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backward-seeking frame in video get stuck
1 participant