Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume fragment loading after level switch follows level error #5537

Merged
merged 1 commit into from Jun 5, 2023

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Jun 2, 2023

This PR will...

Resume fragment loading after level switch follows level error

Why is this Pull Request needed?

The stream-controller gets stuck in WAITING_LEVEL state waiting for the first level that failed to load. The stream-controller's idle tick needs to run to update its level property to match hls.nextLoadLevel so that it will attempt to fetch segments from the current level if available or go back to WAITING_LEVEL for the active level that has yet to load.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Fixes #5498

@robwalch robwalch added this to the 1.5.0 milestone Jun 2, 2023
@robwalch robwalch modified the milestones: 1.5.0, 1.4.5 Jun 5, 2023
@robwalch robwalch merged commit a8d5965 into master Jun 5, 2023
16 checks passed
@robwalch robwalch deleted the bugfix/level-switch-following-level-error branch June 5, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant