Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix live frag finding after detach and re-attach past live window #5742

Merged
merged 1 commit into from Aug 16, 2023

Conversation

robwalch
Copy link
Collaborator

This PR will...

When looking for the next fragment to load, if the target position is less than the start of the playlist, reset startPosition and nextLoadPosition to liveSyncPosition. Setting nextLoadPosition ensures that the audio-stream-controller can properly evaluate the main buffer before SourceBuffers have been added to the MediaSource.

Why is this Pull Request needed?

audio-stream-controller exits before loading anything when main's nextLoadPosition is incorrect in some cases.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Fixes #5741

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.5.0 milestone Aug 16, 2023
@robwalch robwalch merged commit c6395f9 into master Aug 16, 2023
16 checks passed
@robwalch robwalch deleted the bugfix/resync-live-reattached branch August 16, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live video not playling in safari after media detach and attach again
1 participant