Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config flag for maximum front buffer frontBufferFlushThreshold #5761

Merged
merged 1 commit into from Aug 31, 2023

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Aug 22, 2023

This PR will...

Allow users to specify a maximum forward buffer to give control of media buffer memory usage.

Why is this Pull Request needed?

Some devices have poor MSE buffer cleanup and run out of memory instead of evicting segments far ahead of the playhead.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Fixes #5479
Fixes #5587

Authored by

@iamboorrito

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.5.0 milestone Aug 22, 2023
@robwalch robwalch merged commit 301be58 into master Aug 31, 2023
17 checks passed
@robwalch robwalch deleted the feature/flushFrontBuffer branch August 31, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playback fails after QuotaExceededError Flush Front Buffer
2 participants