Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset init segment when M2TS video configuration changes #5794

Merged
merged 1 commit into from Sep 5, 2023

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Sep 1, 2023

This PR will...

Reset init segment when M2TS video configuration changes

Why is this Pull Request needed?

Some MSE implementations do not handle video configuration (resolution) changes without appending a new init segment or changeType append to prepare the decoder for the change.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Resolves #2062 (and stale duplicates #1842 #967)

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.5.0 milestone Sep 1, 2023
@robwalch robwalch merged commit d0d5204 into master Sep 5, 2023
16 checks passed
@robwalch robwalch deleted the bugfix/reset-init-segment-on-m2ts-sps-change branch September 5, 2023 17:28
@robwalch robwalch mentioned this pull request Sep 23, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hls.js can not play correctly a live stream with multiple dimensions
1 participant