Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch on smaller fmp4 segments that align with buffered segment boundaries #5804

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Sep 7, 2023

This PR will...

Switch on smaller fmp4 segments that align with buffered segment boundaries

Why is this Pull Request needed?

Prevents vide buffer gaps from being produced on append in Chrome with HLS assets with fmp4 segments of different durations as in #5743.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Fixes #5743

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch force-pushed the bugfix/chrome-avc-overlap-fmp4 branch from c056878 to 3f093a5 Compare September 7, 2023 23:07
@robwalch robwalch merged commit a594323 into master Sep 8, 2023
15 of 16 checks passed
@robwalch robwalch deleted the bugfix/chrome-avc-overlap-fmp4 branch September 8, 2023 21:12
@robwalch robwalch mentioned this pull request Sep 12, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There are videos where buffer stalls always occur.
1 participant