Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support #EXT-X-BYTERANGE before #EXT-X-MAP tag #5850

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Sep 26, 2023

This PR will...

  • Support #EXT-X-BYTERANGE before #EXT-X-MAP tag
  • Update Fragment byteRange, byteRangeEndOffset, byteRangeStartOffset typing to reflect actual return types.
    • fragment.byteRange returns a number tuple or an empty array
    • byteRangeEndOffset and byteRangeStartOffset both return numbers or both return undefined

Why is this Pull Request needed?

Handle odd tag order in media playlists and better reflect data types.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch force-pushed the feature/byterange-before-map-tag branch from e78e89f to 360652b Compare September 26, 2023 03:09
@robwalch robwalch added this to the 1.5.0 milestone Sep 29, 2023
@robwalch robwalch merged commit 7c7c39f into master Sep 29, 2023
13 of 15 checks passed
@robwalch robwalch deleted the feature/byterange-before-map-tag branch September 29, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant