Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in M2TS probe introduced in #5503 #5858

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Sep 30, 2023

This PR will...

  • Avoid false positive in M2TS probe where sync byte is not either followed by another sync byte at packet length or is at packet length from the end of the payload
  • Reset item related properties in stream-controller onManifestLoading not handled by stopLoad, startLoad, or onManifestLoaded in base controller
  • Fix ADTS error handling and tests

Why is this Pull Request needed?

Fixes case where M2TS probe incorrectly exits early

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Closes #5857

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.5.0 milestone Sep 30, 2023
@robwalch robwalch force-pushed the bugfix/ts-probe-sync-byte-not-packet branch from 6aa427a to 31e998a Compare October 1, 2023 20:49
@robwalch robwalch merged commit 6dbc197 into master Oct 2, 2023
15 of 16 checks passed
@robwalch robwalch deleted the bugfix/ts-probe-sync-byte-not-packet branch October 2, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The video can be played in 1.4.3 but not in 1.4.4+
1 participant