Fix detach attach behavior dropping one of two SourceBuffers #5974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix SourceBuffer reset regression introduced in dev with #5911 (not reproducible in v1.14.x).
Why is this Pull Request needed?
_bufferCodecEventsTotalshould not be reset on BUFFER_CODECS. It is only set once on manifest parsed and its value is needed to reset SourceBuffers on detach/attach or recoverMediaError with unmuxed HLS assets.Are there any points in the code the reviewer needs to double check?
We may want to replace
_bufferCodecEventsTotalandbufferCodecEventsExpectedwith a map of tracks/SourceBuffer types ('audio' and/or 'video' or 'audiovideo') to manage SourceBuffer creation on init segment parsed. If you have trouble with MSE setup/reset or an irregular stream like #1510 leave a comment or file an issue mentioning this note.Resolves issues:
Checklist