Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ID3 TextTrack Cue fixes for PlayStation4 #6021

Merged
merged 1 commit into from Dec 6, 2023
Merged

ID3 TextTrack Cue fixes for PlayStation4 #6021

merged 1 commit into from Dec 6, 2023

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Dec 6, 2023

This PR will...

  • Remove the use of deprecated WebKitDataCue
  • If setting custom properties on a VTTCue or TextTrackCue throws, create a new instance with the data fields serialized as JSON in the cue text

Why is this Pull Request needed?

PlayStation4 throws when using undefined result from new Cue.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Fixes #6020

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.5.0 milestone Dec 6, 2023
@robwalch robwalch mentioned this pull request Dec 6, 2023
Merged
3 tasks
@robwalch robwalch merged commit 5e972ca into master Dec 6, 2023
15 of 16 checks passed
@robwalch robwalch deleted the bugfix/id3-cue-creation-ps4 branch December 6, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agajassi agajassi agajassi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

ID3s Are Not Getting Processed On Play Station 4
2 participants
@robwalch @agajassi