Support startLevel above max level index
#6190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix regression that removed (unofficial) support for
startLevelabove max level index. Update docs to note thatstartLevelshould be set to a valid level index.Why is this Pull Request needed?
Setting
startLevelto Infinity is used to start on max level index even though the player emits a non-fatal error. Since the error is non-fatal playback and streaming should not fail.Are there any points in the code the reviewer needs to double check?
Changing stream-controller
startLoadlogic can have side-effects. This change is an improvement that will keep the stream-controller's level index aligned with the level controllers load level index.Resolves issues:
Fixes #6172
Checklist