Determine canSkip based on age of last playlist request #6300
+42
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
requested changes
Mar 27, 2024
robwalch
requested changes
Apr 2, 2024
robwalch
reviewed
Apr 2, 2024
robwalch
reviewed
Apr 2, 2024
mcintyrehh
commented
Apr 3, 2024
robwalch
previously approved these changes
Apr 3, 2024
robwalch
previously approved these changes
Apr 4, 2024
robwalch
approved these changes
Apr 5, 2024
iamboorrito
approved these changes
Apr 8, 2024
robwalch
pushed a commit
that referenced
this pull request
Apr 10, 2024
(cherry picked from commit d802d60)
robwalch
added a commit
that referenced
this pull request
Apr 11, 2024
* patch/v1.5.x: Bugfix: Patch for light player exception with audio groups (#6342) Do not use "levelCodec" to instantiate SourceBuffer when multiple audio codec strings are present in the Multivariant Playlist variant CODECS attribute with muxed content (#6341) Bugfix: preferManagedMediaSource:false when MSE is not present (#6338) Determine canSkip based on age of last playlist request (#6300) API.md update removeLevel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Determine whether the
_HLS_skipparam should be added based on the age of the last Level request. This check is also completed immediately before the next Level request.Why is this Pull Request needed?
The previous
getSkipValuelogic was calculating the_HLS_skipparam by comparing CAN-SKIP-UNTIL seconds, tosnChangeGoalin segments.This update proposes new logic to determine if we should skip segments based on the age of the last playlist request. The HLS Spec mentions the following in 6.3.7 - Requesting Playlist Delta Updates:
The
getSkipValuemethod was previously getting called in the BasePlaylistController'splaylistLoadedmethod, where the playlist age would be a fraction of a second. It has been moved into theloadPlaylistmethod to ensure that we are checking the age of the previous playlist call immediately before the new playlist request is made.Are there any points in the code the reviewer needs to double check?
Delta Playlist stream I've been testing with from the THEO Player test page:
https://cdn-vos-ppp-01.vos360.video/Content/HLS_HLSCLEAR/Live/channel(PPP-LL-2HLS)/index.m3u8
I haven't tested with a stream that only has the
CAN-SKIP-UNTILdirective and noCAN-BLOCK-RELOAD, so I'd like to test that case to make sure there are no regressions to: #3670Resolves issues:
Checklist