Pushing fix for CC cues not stopping when switching media #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I have two sources with inline CC, swapping between them causes some CC from the previous source to appear mixed in with the CC of the new source, and continue to update. I am calling detachMedia before swapping to the new source. For VOD to VOD swaps, this mixing lasts only for a couple of fragments. For Live to VOD, I am seeing lingering mixing that lasts for a longer time.
By clearing the cues on the detach media listener in TimelineController, it stops the lingering CC cues. I have tested this with VOD to VOD, live to VOD and VOD to live and it appears to solve the issue.