Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use performance timers for stats #87

Merged
merged 1 commit into from Nov 23, 2015
Merged

Use performance timers for stats #87

merged 1 commit into from Nov 23, 2015

Conversation

kanongil
Copy link
Contributor

This makes the measurements more precise & monotonic, eg. avoiding issues when the local system time is adjusted.

Note that the measurements will have an arbitrary base and can't be compared using a regular Date.now(). This is new behavior but doesn't change any of the internal calculations that all rely on deltas.

This makes the measurements more precise & monotonic
@mangui
Copy link
Member

mangui commented Nov 23, 2015

http://caniuse.com/#search=performance
indeed Safari does not seem supported ?

@kanongil
Copy link
Contributor Author

Huh? It works for me in Safari, and displays as such on caniuse.com (http://caniuse.com/#feat=high-resolution-time).

As far as I can tell, it works on all browsers with MSE support, though I haven't done extensive testing.

@mangui
Copy link
Member

mangui commented Nov 23, 2015

ok great, sorry I was looking at the wrong API.

mangui added a commit that referenced this pull request Nov 23, 2015
Use performance timers for stats
@mangui mangui merged commit 9ebf2ed into video-dev:master Nov 23, 2015
@tjenkinson
Copy link
Member

I think maybe there should be a polyfill because it doesn't look like it might be supported that well on mobiles.

https://developer.mozilla.org/en-US/docs/Web/API/Performance/now

On 23 Nov 2015, at 16:58, Guillaume du Pontavice notifications@github.com wrote:

Merged #87.


Reply to this email directly or view it on GitHub.

@mangui
Copy link
Member

mangui commented Nov 23, 2015

as long as it is supported on mobile supporting MSE, that should do the trick.
working fine on Chrome Mobile/Android and FF mobile/Android

johnBartos pushed a commit that referenced this pull request Jun 27, 2018
Remove Firefox code that shifts captions to the side
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants