Fix latest golangci-lint violations

video-dev · Sep 26, 2019 · c8afaf6 · c8afaf6
1 parent 7873028
commit c8afaf6
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 7 deletions.
diff --git a/internal/provider/bitmovin/bitmovin.go b/internal/provider/bitmovin/bitmovin.go
@@ -825,7 +825,6 @@ func (p *bitmovinProvider) Transcode(job *db.Job) (*provider.JobStatus, error) {
 				var audioStreamID, videoStreamID string
 
 				if !isRepeatedAudio {
-
 					audioStream := &models.Stream{
 						CodecConfigurationID: &audioPresetID,
 						InputStreams:         aiss,

diff --git a/internal/provider/encodingcom/encodingcom_test.go b/internal/provider/encodingcom/encodingcom_test.go
@@ -1001,7 +1001,6 @@ func TestCreatePreset(t *testing.T) {
 	if !reflect.DeepEqual(fakePreset.Request.Format[0], expectedFormat) {
 		pretty.Fdiff(os.Stderr, fakePreset.Request.Format[0], expectedFormat)
 		t.Errorf("wrong format provided\nWant %#v\nGot  %#v", expectedFormat, fakePreset.Request.Format[0])
-
 	}
 }
 
@@ -1103,7 +1102,6 @@ func TestCreatePresetTwoPass(t *testing.T) {
 	if !reflect.DeepEqual(fakePreset.Request.Format[0], expectedFormat) {
 		pretty.Fdiff(os.Stderr, fakePreset.Request.Format[0], expectedFormat)
 		t.Errorf("wrong format provided\nWant %#v\nGot  %#v", expectedFormat, fakePreset.Request.Format[0])
-
 	}
 }
 

diff --git a/internal/provider/hybrik/hybrik.go b/internal/provider/hybrik/hybrik.go
@@ -206,7 +206,6 @@ func (hp *hybrikProvider) presetsToTranscodeJob(job *db.Job) (string, error) {
 	}
 
 	// create transcode elements for each target
-	// TODO: This can be optimized further with regards to combining tasks so that they run in the same machine. Requires some discussion
 	for _, output := range job.Outputs {
 		presetID, ok := output.Preset.ProviderMapping[Name]
 		if !ok {
@@ -303,7 +302,6 @@ func (hp *hybrikProvider) presetsToTranscodeJob(job *db.Job) (string, error) {
 				},
 			},
 		)
-
 	}
 
 	resp, err := json.Marshal(cj)
@@ -408,8 +406,6 @@ func (hp *hybrikProvider) CreatePreset(preset db.Preset) (string, error) {
 	videoProfile := strings.ToLower(preset.Video.Profile)
 	videoLevel := preset.Video.ProfileLevel
 
-	// TODO: Understand video-transcoding-api profile + level settings in relation to vp8
-	// For now, we will omit and leave to encoder defaults
 	if preset.Video.Codec == "vp8" {
 		videoProfile = ""
 		videoLevel = ""