Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dashSource component for an dash player integration #275

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

RajnishKatharotiya
Copy link

Currently, in player's documentation, HLSSource integration is only one thing described in under customSource headline. So when I wanted dash support with this player I had to search and go through the code of player to understand.

So, In this commit, I have added dashSource component explanation after HLSSource component into the customiseSource tab.

@codecov-io
Copy link

codecov-io commented May 26, 2019

Codecov Report

Merging #275 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #275   +/-   ##
======================================
  Coverage    44.9%   44.9%           
======================================
  Files          46      46           
  Lines        1216    1216           
======================================
  Hits          546     546           
  Misses        670     670

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bc8b22...5571f13. Read the comment docs.

docs/lib/examples/CustomizeDashSource.js Outdated Show resolved Hide resolved
docs/lib/examples/CustomizeDashSource.js Outdated Show resolved Hide resolved
docs/lib/examples/CustomizeDashSource.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
- Removed unnecessary method from DashSource component.
- Set dashjs package in alphabetically order into dependency list
@RajnishKatharotiya
Copy link
Author

I have pushed all requested changes into #275 f23f040 . So, please check that.

@RajnishKatharotiya
Copy link
Author

Hi @mondaychen , I have pushed all requested changes into #275 5571f13. So, Please check this.

@mondaychen
Copy link
Member

I got this error when trying to run your branch:

ERROR in ReferenceError: dashjs is not defined
    at Object../node_modules/dashjs/build/es5/src/streaming/metrics/utils/DVBErrorsTranslator.js (evalmachine.<anonymous>:24417:1676)
    at __webpack_require__ (evalmachine.<anonymous>:30:30)
    at Object../node_modules/dashjs/build/es5/src/streaming/metrics/MetricsReporting.js (evalmachine.<anonymous>:23747:178)
    at __webpack_require__ (evalmachine.<anonymous>:30:30)
    at Object../node_modules/dashjs/build/es5/index.js (evalmachine.<anonymous>:18138:327)
    at __webpack_require__ (evalmachine.<anonymous>:30:30)
    at Object../docs/lib/examples/DashSource.js (evalmachine.<anonymous>:2040:38)
    at __webpack_require__ (evalmachine.<anonymous>:30:30)
    at Object../docs/lib/examples/CustomizeDashSource.js (evalmachine.<anonymous>:1952:42)
    at __webpack_require__ (evalmachine.<anonymous>:30:30)

I have dashjs@2.9.3

Do you know how to fix this?

Rajnish Katharotiya added 2 commits October 7, 2020 14:59
- Resolved issue of undefined dashjs.
…nto feature-dashsource_example_into_docs
@RajnishKatharotiya
Copy link
Author

@mondaychen dashjs isn't supporting properly with npm so have added dash.min.js file inside assets and removed npm import. So, now it'll work fine.
Can you please check again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants