-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dashSource component for an dash player integration #275
base: master
Are you sure you want to change the base?
Added dashSource component for an dash player integration #275
Conversation
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
======================================
Coverage 44.9% 44.9%
======================================
Files 46 46
Lines 1216 1216
======================================
Hits 546 546
Misses 670 670 Continue to review full report at Codecov.
|
- Removed unnecessary method from DashSource component. - Set dashjs package in alphabetically order into dependency list
Hi @mondaychen , I have pushed all requested changes into #275 5571f13. So, Please check this. |
I got this error when trying to run your branch:
I have dashjs@2.9.3 Do you know how to fix this? |
- Resolved issue of undefined dashjs.
…nto feature-dashsource_example_into_docs
@mondaychen dashjs isn't supporting properly with npm so have added dash.min.js file inside assets and removed npm import. So, now it'll work fine. |
Currently, in player's documentation, HLSSource integration is only one thing described in under customSource headline. So when I wanted dash support with this player I had to search and go through the code of player to understand.
So, In this commit, I have added dashSource component explanation after HLSSource component into the customiseSource tab.