New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not exclude node modules from babel #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that Babel is still not being run for ES6 modules, so I think this makes sense.
do we have dependencies that ship es6 code hidden in es modules? |
Any plugin that uses the generator that depends on another plugin that uses the generator will have this problem, because rollup prioritizes the |
Is the |
shouldn't the es module basically be the source code all bundled together without any transpiration to es5? For instance a class stays a class. |
no, the |
After further discussion it appears that the es dist should be babeled and I was wrong. https://github.com/rollup/rollup/wiki/pkg.module#wait-it-just-means-import-and-export--not-other-future-javascript-features Closing this in favor of #196 which brings that functionality back. |
In order to get many of the size benefits from rollup/es6 code we want to use es6 versions of sub modules. Right now that is what we do, but it causes syntax errors (especially on ie 11) since anything in node_modules won't be converted to es5 and will remain es6.