fix: rename HAVE_MASTER to HAVE_MAIN_MANIFEST #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING_CHANGE: rename HAVE_MASTER to HAVE_MAIN_MANIFEST
Codecov Report
@@ Coverage Diff @@
## rename-things #1310 +/- ##
==============================================
Coverage 86.22% 86.22%
==============================================
Files 39 39
Lines 9757 9757
Branches 2276 2276
==============================================
Hits 8413 8413
Misses 1344 1344
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This PR is ready, checks failure is codecov. |
misteroneill
approved these changes
Aug 17, 2022
…ain prop rename & rename manifest.js exports & media groups isMainPlaylist & mainPlaylistLoader_ & PlaylistController#main() (#1311) * test: rename test manifest names * updateMain rename, and .main prop rename BREAKING CHANGE: playlist loaders updateMain and .main prop rename * rename manifest.js exports BREAKING CHANGE: manifest.js exports mainForMedia and addPropertiesToMain * media groups isMainPlaylist BREAKING CHANGE: rename media groups prop to isMainPlaylist * mainPlaylistLoader_ BREAKING CHANGE: rename property to mainPlaylistLoader_ * PlaylistController#main() (#1317) BREAKING CHANGE: rename to PlaylistController#main()
gkatsev
added a commit
that referenced
this pull request
Aug 17, 2022
* fix: rename HAVE_MASTER to HAVE_MAIN_MANIFEST BREAKING_CHANGE: rename HAVE_MASTER to HAVE_MAIN_MANIFEST * test: rename test manifest names * updateMain rename, and .main prop rename BREAKING CHANGE: playlist loaders updateMain and .main prop rename * rename manifest.js exports BREAKING CHANGE: manifest.js exports mainForMedia and addPropertiesToMain * media groups isMainPlaylist BREAKING CHANGE: rename media groups prop to isMainPlaylist * mainPlaylistLoader_ BREAKING CHANGE: rename property to mainPlaylistLoader_ * PlaylistController#main() (#1317) BREAKING CHANGE: rename to PlaylistController#main()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING_CHANGE: rename HAVE_MASTER to HAVE_MAIN_MANIFEST