Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for sidx segments #207
This is a sloppy first pass at adding support for SIDX segments. For some background:
A DASH representation can have a
<BaseURL>German_Forest_Short_Poem_german-de-68s-2-lc-128000bps_seg.mp4</ <SegmentBase indexRange="606-805"> <Initialization range="0-605"/> </SegmentBase>
http-streaming currently will immediately end given the above manifest, as it has no way of adding other segments.
SIDX is specified in ISO/IEC 14496-12.
I am using this manifest.
Specific Changes proposed
I expect this need to be refactored to fit better within http-streaming. Currently, it:
Still needs tests.
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
I took a look at what's happening, and there's two problems:
Doing the 2nd is non-trivial with the structure of the project, so I wound up starting on an alternative set of PRs. For 1, you can follow videojs/mpd-parser#41 and I'll post a WIP PR for the VHS portion of 2 too. Also, thanks for the mux.js PR!