feat: add option to cache encrpytion keys in the player #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldayananda
reviewed
Mar 28, 2019
src/segment-loader.js
Outdated
| let storedKey = this.keyCache_[id]; | ||
|
|
||
| if (this.cacheEncryptionKeys_ && set && !storedKey && key.bytes) { | ||
| this.keyCache_[id] = storedKey = { |
There was a problem hiding this comment.
we may also want to check if the key has actually changed? I suppose this would only be if the iv value is different
There was a problem hiding this comment.
A change in IV does not mean the key has changed. Probably the proper approach is to check for the HTTP Expires header and invalidate our cache based on that per https://tools.ietf.org/html/draft-pantos-http-live-streaming-23#section-6.2.3
ldayananda
reviewed
Mar 28, 2019
ldayananda
previously approved these changes
Mar 28, 2019
ldayananda
reviewed
Mar 29, 2019
src/segment-loader.js
Outdated
| @@ -347,6 +347,8 @@ export default class SegmentLoader extends videojs.EventTarget { | |||
| const id = initSegmentId(map); | |||
| let storedMap = this.initSegments_[id]; | |||
|
|
|||
| // TODO: We should use the HTTP Expires header to invalidate our cache per | |||
| // https://tools.ietf.org/html/draft-pantos-http-live-streaming-23#section-6.2.3 | |||
There was a problem hiding this comment.
Whoops, this accidentally ended up in the initSegment method instead of segmentKey
ldayananda
changed the title
* add integration test for cached encryption key * add unit tests * adding segment-loader test * adding some comments per CR and a negative case for cacheEncryptionKeys: false * negative test for cacheEncryptionKeys:false
ldayananda
approved these changes
Mar 29, 2019
gkatsev
approved these changes
Apr 1, 2019
|
Just add this to your options and it will be cached. I was suffering from the same issue with latest build, and finally figured it out html5: {
vhs: {
cacheEncryptionKeys: true
}
}notice the vhs, not hls :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an option to force the player to cache encryption keys instead of requesting for every segment. Defaults to
falsefor backwards compatibility.Addressess #140
todo/future enhancement: Use HTTP Expires header to expire our internal cache per https://tools.ietf.org/html/draft-pantos-http-live-streaming-23#section-6.2.3