-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for dash manifests describing sidx boxes #455
Commits on Mar 11, 2019
-
Adding initial tests to ensure coverage of states and events
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 3a9a95d - Browse repository at this point
Copy the full SHA 3a9a95dView commit details -
Initial implementation of code changes:
- start DashPlaylistLoader in HAVE_NOTHING state - enter HAVE_METADATA in media() method - set media automatically only for child playlist loader as masterPlaylistLoader is set from masterPlaylistController update tests with desired behavior ensure loadedmetadata is triggered after loadedplaylist remove unnecessary media playlist selection for master loader
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 13c2f0a - Browse repository at this point
Copy the full SHA 13c2f0aView commit details -
ldayananda committed
Mar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 5aa5d16 - Browse repository at this point
Copy the full SHA 5aa5d16View commit details -
loadedplaylist should happen twice, once when the master manifest ret…
…urns and once when the initial media is selected
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 0fd7f87 - Browse repository at this point
Copy the full SHA 0fd7f87View commit details -
- delay triggering selectedinitialmedia event until the active audio playlist loader is finished setting media - ensure that HLS playlists without alternate audio are not affected
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 85049e8 - Browse repository at this point
Copy the full SHA 85049e8View commit details -
- don't autoselect media for the masterPlaylistLoader as that is done by MasterPlaylistController - ensure updateMaster returns null if there are no changes in the playlist
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for ff40727 - Browse repository at this point
Copy the full SHA ff40727View commit details -
- trigger loadedmetadata as part of haveMetadata - add some comments to explain why we trigger certain events and set media at points
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 67c92cc - Browse repository at this point
Copy the full SHA 67c92ccView commit details -
- moving haveMetadata to a class-level method, more comments. - remove setTimeouts as they were not performing a necessary function. XHR requests can return in any amount of time and HLS PlaylistLoader handles any requests within a callback, or returns if a request need not be made. DASH should do the same - cleanup the minimumUpdatePeriod setup - remove unnecessary clock.ticks from tests
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for eb14f52 - Browse repository at this point
Copy the full SHA eb14f52View commit details -
only trigger loadedplaylist and loadedmetadata when loading a new VOD…
… playlist
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 1bb3dd4 - Browse repository at this point
Copy the full SHA 1bb3dd4View commit details -
Fix: return to using zero delays to mimic asynchronous code in start …
…and media
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 9aab16d - Browse repository at this point
Copy the full SHA 9aab16dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65b9d0e - Browse repository at this point
Copy the full SHA 65b9d0eView commit details -
ldayananda committed
Mar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 02c8595 - Browse repository at this point
Copy the full SHA 02c8595View commit details -
ldayananda committed
Mar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 6723894 - Browse repository at this point
Copy the full SHA 6723894View commit details -
fix: mock loader.hasPendingRequest for functional tests
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 6ebf1d2 - Browse repository at this point
Copy the full SHA 6ebf1d2View commit details -
both haveMaster and haveMetadata can use zero delays. Update docs to …
…mention hasPendingRequest for fallback media selection
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for fafa47e - Browse repository at this point
Copy the full SHA fafa47eView commit details -
ldayananda committed
Mar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for b5f24dd - Browse repository at this point
Copy the full SHA b5f24ddView commit details -
ldayananda committed
Mar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 8a34323 - Browse repository at this point
Copy the full SHA 8a34323View commit details -
move sidx requesting into the dash playlist loader
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for f7195dc - Browse repository at this point
Copy the full SHA f7195dcView commit details -
first master playlist load complete
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for ecd9699 - Browse repository at this point
Copy the full SHA ecd9699View commit details -
ldayananda committed
Mar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for e3109dc - Browse repository at this point
Copy the full SHA e3109dcView commit details -
ldayananda committed
Mar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 55e02c2 - Browse repository at this point
Copy the full SHA 55e02c2View commit details -
slight change to make things clearer
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 38c11a3 - Browse repository at this point
Copy the full SHA 38c11a3View commit details -
request segment base sidxes for media groups also
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for e320129 - Browse repository at this point
Copy the full SHA e320129View commit details -
ldayananda committed
Mar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for c3d39f1 - Browse repository at this point
Copy the full SHA c3d39f1View commit details -
ldayananda committed
Mar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 97e37d6 - Browse repository at this point
Copy the full SHA 97e37d6View commit details -
- correcting merge mistake - moving check for sidx to correct place
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 31c8ad8 - Browse repository at this point
Copy the full SHA 31c8ad8View commit details -
- update to request sidx on a playlist basis
- have parseMasterXml use previously downloaded sidxes when refreshing media
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 420fe73 - Browse repository at this point
Copy the full SHA 420fe73View commit details -
fix: store sidxInfo reference before making request for sidx
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 77a8e9f - Browse repository at this point
Copy the full SHA 77a8e9fView commit details -
ldayananda committed
Mar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 7c74d4b - Browse repository at this point
Copy the full SHA 7c74d4bView commit details -
add integration tests for sidx
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for e80ad0a - Browse repository at this point
Copy the full SHA e80ad0aView commit details -
- haveMaster - parseMasterXml - handleSidxResponse_ - requestSidx_
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 4dd41fd - Browse repository at this point
Copy the full SHA 4dd41fdView commit details -
- add unit tests for setupChildLoader, hasPendingRequest - add functional test to check if requests are made for sidx boxes
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 3d101f8 - Browse repository at this point
Copy the full SHA 3d101f8View commit details -
tests: added test for asynch haveMaster handling
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 795f420 - Browse repository at this point
Copy the full SHA 795f420View commit details -
ldayananda committed
Mar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 089d874 - Browse repository at this point
Copy the full SHA 089d874View commit details -
tests: update handleSidxResponse tests to use class method and check …
…error case
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 94fb586 - Browse repository at this point
Copy the full SHA 94fb586View commit details -
add support for sidx info changing in a live playlist
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 859d111 - Browse repository at this point
Copy the full SHA 859d111View commit details -
ldayananda committed
Mar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for ca459b4 - Browse repository at this point
Copy the full SHA ca459b4View commit details -
fixes for filterSidxMapping and utilities and tests
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for d42cf8a - Browse repository at this point
Copy the full SHA d42cf8aView commit details -
ldayananda committed
Mar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 870c8cc - Browse repository at this point
Copy the full SHA 870c8ccView commit details -
add redirect support for sidx requests
ldayananda committedMar 11, 2019 Configuration menu - View commit details
-
Copy full SHA for e2b8754 - Browse repository at this point
Copy the full SHA e2b8754View commit details
Commits on Apr 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 3bf1d12 - Browse repository at this point
Copy the full SHA 3bf1d12View commit details
Commits on Apr 8, 2019
-
store response, if any. We aren't allowed to read responseText since …
…responseType was set to arraybuffer
Configuration menu - View commit details
-
Copy full SHA for 7454652 - Browse repository at this point
Copy the full SHA 7454652View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dafa87 - Browse repository at this point
Copy the full SHA 0dafa87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fe8dbb - Browse repository at this point
Copy the full SHA 0fe8dbbView commit details
Commits on Apr 11, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 4291943 - Browse repository at this point
Copy the full SHA 4291943View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e00023 - Browse repository at this point
Copy the full SHA 9e00023View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9fc3b0 - Browse repository at this point
Copy the full SHA a9fc3b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef6f39c - Browse repository at this point
Copy the full SHA ef6f39cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 60c009e - Browse repository at this point
Copy the full SHA 60c009eView commit details -
Configuration menu - View commit details
-
Copy full SHA for daa8c0f - Browse repository at this point
Copy the full SHA daa8c0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e4155c6 - Browse repository at this point
Copy the full SHA e4155c6View commit details