Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for dash manifests describing sidx boxes #455

Merged
merged 51 commits into from
Apr 12, 2019

Commits on Mar 11, 2019

  1. Configuration menu
    Copy the full SHA
    3a9a95d View commit details
    Browse the repository at this point in the history
  2. Initial implementation of code changes:

    - start DashPlaylistLoader in HAVE_NOTHING state
    - enter HAVE_METADATA in media() method
    - set media automatically only for child playlist loader as masterPlaylistLoader is set from masterPlaylistController
    
    update tests with desired behavior
    
    ensure loadedmetadata is triggered after loadedplaylist
    
    remove unnecessary media playlist selection for master loader
    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    13c2f0a View commit details
    Browse the repository at this point in the history
  3. fixes live manifests

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    5aa5d16 View commit details
    Browse the repository at this point in the history
  4. loadedplaylist should happen twice, once when the master manifest ret…

    …urns and once when the initial media is selected
    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    0fd7f87 View commit details
    Browse the repository at this point in the history
  5. Fix eme setup:

    - delay triggering selectedinitialmedia event until the active audio playlist loader is finished setting media
    
    - ensure that HLS playlists without alternate audio are not affected
    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    85049e8 View commit details
    Browse the repository at this point in the history
  6. Fixes:

    - don't autoselect media for the masterPlaylistLoader as that is done by MasterPlaylistController
    - ensure updateMaster returns null if there are no changes in the playlist
    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    ff40727 View commit details
    Browse the repository at this point in the history
  7. Cleanup:

    - trigger loadedmetadata as part of haveMetadata
    - add some comments to explain why we trigger certain events and set media at points
    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    67c92cc View commit details
    Browse the repository at this point in the history
  8. Cleanup:

    - moving haveMetadata to a class-level method, more comments.
    
    - remove setTimeouts as they were not performing a necessary function. XHR requests can return in any amount of time and HLS PlaylistLoader handles any requests within a callback, or returns if a request need not be made. DASH should do the same
    
    - cleanup the minimumUpdatePeriod setup
    
    - remove unnecessary clock.ticks from tests
    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    eb14f52 View commit details
    Browse the repository at this point in the history
  9. only trigger loadedplaylist and loadedmetadata when loading a new VOD…

    … playlist
    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    1bb3dd4 View commit details
    Browse the repository at this point in the history
  10. Fix: return to using zero delays to mimic asynchronous code in start …

    …and media
    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    9aab16d View commit details
    Browse the repository at this point in the history
  11. docs:

    - fix up a comment
    - add idea for media groups refactor
    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    65b9d0e View commit details
    Browse the repository at this point in the history
  12. remove comment

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    02c8595 View commit details
    Browse the repository at this point in the history
  13. fix: media selection fallback

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    6723894 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    6ebf1d2 View commit details
    Browse the repository at this point in the history
  15. both haveMaster and haveMetadata can use zero delays. Update docs to …

    …mention hasPendingRequest for fallback media selection
    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    fafa47e View commit details
    Browse the repository at this point in the history
  16. initial work

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    b5f24dd View commit details
    Browse the repository at this point in the history
  17. add scaffolding

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    8a34323 View commit details
    Browse the repository at this point in the history
  18. move sidx requesting into the dash playlist loader

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    f7195dc View commit details
    Browse the repository at this point in the history
  19. first master playlist load complete

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    ecd9699 View commit details
    Browse the repository at this point in the history
  20. make parseMasterXml async

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    e3109dc View commit details
    Browse the repository at this point in the history
  21. fix test

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    55e02c2 View commit details
    Browse the repository at this point in the history
  22. slight change to make things clearer

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    38c11a3 View commit details
    Browse the repository at this point in the history
  23. request segment base sidxes for media groups also

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    e320129 View commit details
    Browse the repository at this point in the history
  24. clean up code a bit

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    c3d39f1 View commit details
    Browse the repository at this point in the history
  25. CR comments

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    97e37d6 View commit details
    Browse the repository at this point in the history
  26. fix:

    - correcting merge mistake
    - moving check for sidx to correct place
    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    31c8ad8 View commit details
    Browse the repository at this point in the history
  27. - update to request sidx on a playlist basis

    - have parseMasterXml use previously downloaded sidxes when refreshing media
    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    420fe73 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    77a8e9f View commit details
    Browse the repository at this point in the history
  29. clean up request code

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    7c74d4b View commit details
    Browse the repository at this point in the history
  30. add integration tests for sidx

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    e80ad0a View commit details
    Browse the repository at this point in the history
  31. tests: add unit tests for:

    - haveMaster
    - parseMasterXml
    - handleSidxResponse_
    - requestSidx_
    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    4dd41fd View commit details
    Browse the repository at this point in the history
  32. tests:

    - add unit tests for setupChildLoader, hasPendingRequest
    - add functional test to check if requests are made for sidx boxes
    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    3d101f8 View commit details
    Browse the repository at this point in the history
  33. tests: added test for asynch haveMaster handling

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    795f420 View commit details
    Browse the repository at this point in the history
  34. fixing rebase mistake

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    089d874 View commit details
    Browse the repository at this point in the history
  35. tests: update handleSidxResponse tests to use class method and check …

    …error case
    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    94fb586 View commit details
    Browse the repository at this point in the history
  36. add support for sidx info changing in a live playlist

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    859d111 View commit details
    Browse the repository at this point in the history
  37. tests: refreshXml_

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    ca459b4 View commit details
    Browse the repository at this point in the history
  38. fixes for filterSidxMapping and utilities and tests

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    d42cf8a View commit details
    Browse the repository at this point in the history
  39. linting updates

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    870c8cc View commit details
    Browse the repository at this point in the history
  40. add redirect support for sidx requests

    ldayananda committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    e2b8754 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2019

  1. Configuration menu
    Copy the full SHA
    3bf1d12 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2019

  1. store response, if any. We aren't allowed to read responseText since …

    …responseType was set to arraybuffer
    gkatsev committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    7454652 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0dafa87 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0fe8dbb View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. update mpd-parser to latest

    gkatsev committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    4291943 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9e00023 View commit details
    Browse the repository at this point in the history
  3. only one will

    gkatsev committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    a9fc3b0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ef6f39c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    60c009e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    daa8c0f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e4155c6 View commit details
    Browse the repository at this point in the history