Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use rollup for build #69

Merged
merged 7 commits into from
Mar 30, 2018
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 10 additions & 5 deletions .babelrc
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
{
"presets": [["env", {
"targets": {
"browsers": ["last 2 versions", "ie 9-11"]
}
}]]
"presets": [
["env", {
"modules": false,
"exclude": ["transform-es2015-typeof-symbol"],
"targets": {
"browsers": ["last 2 versions", "ie 9-11"]
}
}]
],
"plugins": ["external-helpers"]
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not preset env?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably could but since we're targeting IE11 and up, es2015 preset is kind of easier.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either one is fine. The babel team would probably prefer us to use the babel-preset-env, though.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easier for what?

especially because we are targeting IE11 and up if we use env and target browsers properly we can end up with less compiled features and build size will be smaller and work better (on supported browsers)

also env preset can decide if we need es3 stuff automatically by target browsers

4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,7 @@ tmp
test/test-manifests.js
test/test-expected.js
coverage/

# this file is generated and shouldn't be checked in
src/decrypter-worker.worker.js
src/mse/transmuxer-worker.worker.js