Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for crash on missing PTS/DTS in ts-inspector #251

Merged
merged 3 commits into from
Mar 28, 2019
Merged

Fix for crash on missing PTS/DTS in ts-inspector #251

merged 3 commits into from
Mar 28, 2019

Conversation

cmacq2
Copy link
Contributor

@cmacq2 cmacq2 commented Mar 13, 2019

Fixes issue: #250

@mjneil mjneil mentioned this pull request Mar 13, 2019
Closed
@gkatsev
Copy link
Member

gkatsev commented Mar 22, 2019

Should we log a warning that the content may have issues when we see this?

@cmacq2
Copy link
Contributor Author

cmacq2 commented Mar 24, 2019 •
edited
Loading

Maybe? What should be the warning, and how should it be logged? Plain console.warn() ?

@brandonocasey brandonocasey mentioned this pull request Mar 28, 2019
Closed
@gkatsev
Copy link
Member

gkatsev commented Mar 28, 2019

Yeah, just a console.warn or even just a console.log if firstKeyFrame is missing.

@cmacq2 cmacq2 force-pushed the fix-missing-pts-dts-keyframe-crash branch from 9654c23 to 7d5a54a Compare March 28, 2019 20:58
@cmacq2
Copy link
Contributor Author

cmacq2 commented Mar 28, 2019

Updated with a console.warn(). What do you think?

gkatsev
gkatsev approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gkatsev gkatsev merged commit 009f769 into videojs:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cmacq2 @gkatsev