refactor: player.dimension() (#4704)

videojs · Nov 1, 2017 · ad1b47b · ad1b47b
1 parent 9acbcd8
commit ad1b47b
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/src/js/player.js b/src/js/player.js
@@ -659,17 +659,18 @@ class Player extends Component {
     if (value === '') {
       // If an empty string is given, reset the dimension to be automatic
       this[privDimension] = undefined;
-    } else {
+      this.updateStyleEl_();
-      const parsedVal = parseFloat(value);
+      return;
+    }
 
-      if (isNaN(parsedVal)) {
+    const parsedVal = parseFloat(value);
-        log.error(`Improper value "${value}" supplied for for ${dimension}`);
-        return;
-      }
 
-      this[privDimension] = parsedVal;
+    if (isNaN(parsedVal)) {
+      log.error(`Improper value "${value}" supplied for for ${dimension}`);
+      return;
     }
 
+    this[privDimension] = parsedVal;
     this.updateStyleEl_();
   }