Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captions: Fix test that's disabled on IE8, testing iOS7 functionality #1861

Closed
gkatsev opened this issue Feb 13, 2015 · 2 comments
Closed

Captions: Fix test that's disabled on IE8, testing iOS7 functionality #1861

gkatsev opened this issue Feb 13, 2015 · 2 comments

Comments

@gkatsev
Copy link
Member

gkatsev commented Feb 13, 2015

We have a test that tests our shimming of the onchange for iOS7. It is currently disabled on IE8 because it's failing there for some reason.
We need to investigate why it's broken on IE8 and fix it.

@gkatsev
Copy link
Member Author

gkatsev commented Apr 21, 2016

So, looks like the test is broken because you can't trigger custom events on IE8 and document.createEvent doesn't exist there either.
The reason why we need document.createEvent is so that we can trigger a manual change event for iOS7. I can change the test to do feature detection for document.createEvent if that's better, otherwise, I think it's ok to leave as is.
@videojs/core-committers thoughts?

@gkatsev
Copy link
Member Author

gkatsev commented Apr 25, 2016

I'm going to close this because IE8 is the only browser we support that doesn't support createEvent, so, it's more or less synonymous.

@gkatsev gkatsev closed this as completed Apr 25, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants