Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logByType issue in IE10 #3442

Closed
alex-phillips opened this issue Jul 19, 2016 · 4 comments
Closed

logByType issue in IE10 #3442

alex-phillips opened this issue Jul 19, 2016 · 4 comments
Assignees

Comments

@alex-phillips
Copy link
Contributor

Description

I've only noticed this in IE10 (works fine in IE9 and IE11). In the function logByType (in log.js src file), the following error is thrown:

SCRIPT65535: Invalid calling object

If you simply surround the fn(args.map.... call in a try/catch, it solves the issue. However, I don't know if this is the best solution.

Steps to reproduce

Explain in detail the exact steps necessary to reproduce the issue.

  1. Simply run the code in IE10. Although, I was also using the VAST/VPAID plugin.

Results

Expected

No exception to be thrown and VideoJS initialize normally.

Actual

Exception thrown

Error output

SCRIPT65535: Invalid calling object

Additional Information

versions

videojs

Current master branch

browsers

IE10

OSes

Windows *

plugins

VAST/VPAID plugin

@misteroneill
Copy link
Member

Confirmed this and will fix - thanks for catching it @alex-phillips

@alex-phillips
Copy link
Contributor Author

@misteroneill I can quick submit a PR for the try/catch solution if that is preferable to get it merged in faster. Just let me know. Thanks!

@misteroneill
Copy link
Member

@alex-phillips Thanks, but I think I've got something. Will have a PR shortly. 😄

@gkatsev
Copy link
Member

gkatsev commented Jul 25, 2016

Should be fixed in 5.11.0.

@gkatsev gkatsev closed this as completed Jul 25, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants