Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class '.vjs-seeking' doesn't remove when video source was changed. #3765

Closed
helenjer opened this issue Nov 9, 2016 · 2 comments
Closed

Class '.vjs-seeking' doesn't remove when video source was changed. #3765

helenjer opened this issue Nov 9, 2016 · 2 comments

Comments

@helenjer
Copy link

helenjer commented Nov 9, 2016 •
edited
Loading

Description

Seeking-state class '.vjs-seeking' doesn't remove when video source was changed.

Example: http://jsbin.com/cixabutaha/edit?html,output

Steps to reproduce

  1. Start video;
  2. Get seeking state ('seeking' event has already fired, but 'seeked' still not yet) - class '.vjs-seeking' will be added to player object - and see loading spinner visible.
  3. Change video source using .src() method.
  4. See class '.vjs-seeking' wasn't removed from player object and loading spinner still visible on playing video.

Results

Expected

Class '.vjs-seeking' should be removed when video reinits and loading spinner should be hidden.

Actual

Class '.vjs-seeking' wasn't removed and loading spinner stays visible.

Error output

none

Additional Information

versions

videojs

Cheked on 5.12.1

browsers

All

OSes

All
@mister-ben
Copy link
Contributor

Thanks for the detail. Agree, the seeking state ought to be cancelled in this case.

gkatsev added a commit that referenced this issue Dec 8, 2016
@gkatsev
fix: remove vjs-seeking on src change
62c5402 
If you're in a seeking state and the source changed, we should no longer
be in a seeking state.

Fixes #3765.
@gkatsev gkatsev mentioned this issue Dec 8, 2016
Merged
@gkatsev
Copy link
Member

gkatsev commented Dec 8, 2016

Made a PR: #3846.

gkatsev added a commit that referenced this issue Dec 14, 2016
@gkatsev
fix: remove vjs-seeking on src change (#3846)
83cbeec 
If you're in a seeking state and the source changed, we should no longer
be in a seeking state.

Fixes #3765.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gkatsev @mister-ben @helenjer