fix(seeking): don't always pause in mouse down #3886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In chrome 55, something changed which introduced a bug in videojs where if you seeked back, it wouldn't work. This is because we always paused the video in the mousedown handler. Instead, we should create a timer for pausing that is cleared in the mouseup handler or in the mouse move handler. This is so that if someone is seeking by clicking and waiting the video pauses. As soon as we start moving and we get a mousemove event, we can know that it's safe to pause as well. Fixes #3839.
misteroneill
approved these changes
Dec 22, 2016
mehmettaskiner
pushed a commit
to dogusdigital/video.js
that referenced
this pull request
Dec 26, 2016
In chrome 55, something changed which introduced a bug in videojs where if you seeked back, it wouldn't work. This is because we always paused the video in the mousedown handler. Instead, we should create a timer for pausing that is cleared in the mouseup handler or in the mouse move handler. This is so that if someone is seeking by clicking and waiting the video pauses. As soon as we start moving and we get a mousemove event, we can know that it's safe to pause as well. Fixes videojs#3839.
MattiasBuelens
added a commit
to MattiasBuelens/video.js
that referenced
this pull request
Jan 6, 2017
This reverts commit e92db4f.
7 tasks
gkatsev
pushed a commit
that referenced
this pull request
Jan 11, 2017
Previously, seek bar's mousedown handler would first seek the video, then pause it. This can trigger a bug in Chrome 55 where seeking backwards and then immediately pausing can break the video player. Instead, call the super handler last so that we pause the video before we start seeking. Fixes #3839. This reverts commit e92db4f (#3886)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In chrome 55, something changed which introduced a bug in videojs where
if you seeked back, it wouldn't work. This is because we always paused
the video in the mousedown handler.
Instead, we should create a timer for pausing that is cleared in the
mouseup handler or in the mouse move handler. This is so that if someone
is seeking by clicking and waiting the video pauses. As soon as we start
moving and we get a mousemove event, we can know that it's safe to pause
as well.
Fixes #3839.