Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TechOrder accept camelCase and TitleCase tech names #3986

Closed
brandonocasey opened this issue Jan 26, 2017 · 0 comments · Fixed by #4010
Closed

Make TechOrder accept camelCase and TitleCase tech names #3986

brandonocasey opened this issue Jan 26, 2017 · 0 comments · Fixed by #4010

Comments

@brandonocasey
Copy link
Contributor

Description

Currently techOrder only accepts tech names that are camelCase others will be ignored. It would be much more user friendly and closer to other conventions if we accept TitleCase as well.

Proposed Changes
@brandonocasey brandonocasey mentioned this issue Jan 26, 2017
Merged
4 tasks
@gkatsev gkatsev added this to To Do in 6.0 Jan 26, 2017
@brandonocasey brandonocasey mentioned this issue Feb 1, 2017
Merged
6 tasks
@brandonocasey brandonocasey removed this from To Do in 6.0 Feb 1, 2017
brandonocasey added a commit that referenced this issue Feb 2, 2017
@brandonocasey
feat: videojs.getTech works with TitleCase or camelCase names (#…
a8f2e43 
…4010)


* Fixes #3986 
* update `techOptions` to look for `TitleCase`/`camelCase` user tech options
* remove deprecated usage of Tech as Component
* add a unit test to verify that registerTech works
* change defaultTech_ to defaultTechOrder_
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: getTech now accepts TitleCase or camelCase videojs/video.js
1 participant
@brandonocasey