chore: add a release script to makes things easier #4517
Conversation
|
|
||
| echo grunt version:${rtype} | ||
| grunt version:${rtype} | ||
| version=$(./build/bin/version) |
There was a problem hiding this comment.
We may want to use something like this here:
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
version="$("$SCRIPT_DIR"/version)"This will allow you to use the script outside of the root directory of video.js without issues
There was a problem hiding this comment.
I like this idea - I use something similar in my horrible bash scripts. 😉
There was a problem hiding this comment.
I'm not sure we want to allow that, though. I think some of the grunt scripts depend on being in the root.
There was a problem hiding this comment.
I guess we could just have the script cd to the video.js root dir when we start it?
There was a problem hiding this comment.
I'm also a bit weary of changing this script since I know it works as is. I would prefer to just document that you need to run this from the root of the project and we can fix it later if this becomes a problem.
I've been using this to release the 5.x branch for a while. I've also just ran it through http://www.shellcheck.net/