New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segments metadata track is shown when changing source #5553
Comments
If you're reporting a |
Ooh, thanks for the reproducible test case! |
From taking the quickest of looks at this, I think it's because video.js/src/js/tracks/text-track-display.js Line 154 in 6bff3ce
We should probably ensure that text-track-display completely ignores non-visible track types |
It might also make sense to clear the TextTrackList queue on source changes too? |
clearing the event queue makes sense. |
What is special about that "cc1" caption? All the others have a language, but that one just says "cc1". Is there something different about it? |
cc1 is the first caption track for 608 captions which live inside the video data. Not sure if that has language data but we should consider setting one for it as well. |
That is interesting, I thought we were using WebVTT captions in our project, I guess they have turned into 608 captions |
It looks like any caption without a language would trigger this issue. |
I have a fix for this in #5556 |
Description
If you had captions on, and then change the video source, you get some weird text on the screen. The guys on videojs slack thought it was the segments metadata track.
Steps to reproduce
Results
Expected
No captions after changing source.
Actual
Even though closed captions are set to "off" after switching the source, this appears as a caption over the video:
{"bandwidth":915905,"resolution":{"width":960,"height":540},"codecs":"mpra.40.2,avc1.4d401f","byteLength":1046972,"uri":"https://d2zihajmogu5jn.cloudfront.net/bipbop-advanced/gear3/main.ts","timeline":0,"playlist":"gear3/prog_index.m3u8","start":9.976644444444446,"end":19.91992222222223}
Error output
Additional Information
versions
videojs
I've seen it in 7.2.2 and 7.2.4
browsers
Chrome, Firefox, and IE11.
Edge doesn't even show captions.
Mobile Safari doesn't show that bottom "CC" caption option, so it doesn't seem to have the problem.
OSes
Microsoft Windows 10
plugins
None
The text was updated successfully, but these errors were encountered: