Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles/captions button is named incorrectly in the docs #5980

Closed
dpipchenko opened this issue May 7, 2019 · 5 comments · Fixed by #6253
Closed

Subtitles/captions button is named incorrectly in the docs #5980

dpipchenko opened this issue May 7, 2019 · 5 comments · Fixed by #6253

Comments

@dpipchenko
Copy link

Hello,

Please update the list of components here: https://docs.videojs.com/tutorial-components.html
...and here: https://docs.videojs.com/docs/guides/components.html
...to include the correct button name for subtitles/caption.

As I found at https://github.com/videojs/video.js/blob/master/src/js/control-bar/control-bar.js it should be 'subsCapsButton'

It took me a couple of hours to find that (specifically, to disable that button), so will definitely save someone's time in the future.

This is for the latest video.js version at least.

@welcome
Copy link

welcome bot commented May 7, 2019

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@gkatsev
Copy link
Member

gkatsev commented May 17, 2019

The docs in docs.videojs.com/docs is the v5 docs. We probably want to add a header there that says so.
There info in on the current page isn't incorrect, just a bit out of date, apparently.

@dpipchenko
Copy link
Author

Ok, makes sense for that specific link. What about the first link I mentioned? It is for v7 as it says - so should the list be updated there?
Снимок экрана 2019-06-04 в 21 15 00

@gkatsev
Copy link
Member

gkatsev commented Jul 26, 2019

That isn't incorrect. We do have a SubtitlesButton and a CaptionsButton. We default to a SubsCapsButton now (which should be on there but isn't).

@stale
Copy link

stale bot commented Sep 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Sep 24, 2019
@stale stale bot closed this as completed Oct 1, 2019
gkatsev added a commit that referenced this issue Oct 3, 2019
Add SubsCapsButton, SeekToLive and LiveTracker.

Fixes #5980.
@gkatsev gkatsev reopened this Oct 3, 2019
@stale stale bot removed the outdated Things closed automatically by stalebot label Oct 3, 2019
gkatsev added a commit that referenced this issue Oct 3, 2019
Add SubsCapsButton, SeekToLive and LiveTracker.

Fixes #5980.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants