Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Components list #6253

Merged
merged 2 commits into from
Oct 3, 2019
Merged

docs: update Components list #6253

merged 2 commits into from
Oct 3, 2019

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Oct 3, 2019

Add SubsCapsButton, SeekToLive and LiveTracker.

Fixes #5980.

Add SubsCapsButton, SeekToLive and LiveTracker.

Fixes #5980.
@gkatsev gkatsev merged commit 7a85e2a into master Oct 3, 2019
@gkatsev gkatsev deleted the component-docs branch October 3, 2019 17:38
OwenEdwards added a commit that referenced this pull request Oct 4, 2019
Wondering if the recent update to components.md shouldn't also have the note "_(hidden, unless there are relevant tracks)_" next to the `SubsCapsButton` (like all other text track buttons)? Sure, in this case "relevant" is two different kinds of text tracks, but it still holds, doesn't it?

If I'm wrong about this, feel free to dismiss this PR! I just wanted to add it as I didn't see/review the #6253 before it was merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subtitles/captions button is named incorrectly in the docs
2 participants