fix: ensure components added with an index are added in the correct location #6297
Conversation
|
Took me a bit to figure out what was wrong here because the issue is so subtle. Is it possible that fixing this will cause issues from people inserting components at particular indexes? |
|
I only noticed this because the LiveTracker changed the position of an element added by a plugin. I was wondering if this could break anything, but I can't think of a reason to give an index at all other than to set the position in DOM. |
|
Conceptually, I think this is a good change to make. There is some risk of causing problems for advanced use-cases that were relying on the broken behavior, but I think a strong argument can be made that, in this case, that wouldn't constitute a breaking change. |
|
Yeah, makes sense. We can always revert it if we find this causes a major issue. |
* fix: addChild with index should allow for children that are elements (videojs#6644) The fix in videojs#6297 doesn't work where the child to insert before is an element rather than a component, e.g. the video element. Check if the child to insert before is an element, as well as checking if it has an el_ * docs(README): Update CDN version urls (videojs#6658) * fix(fs): don't set player element css props on native fullscreen (videojs#6673) Fixes videojs#6640 * Update description of video.js in the package.json file, and add 'hls' keyword (videojs#6603) * Update descritpion of video.js in the package.json file, and add 'hls' keyword * Update package.json Co-authored-by: Steve Heffernan <git@heff.me> Co-authored-by: mister-ben <git@misterben.me> Co-authored-by: Soroush Chehresa <s1996ch@gmail.com> Co-authored-by: Gary Katsevman <git@gkatsev.com> Co-authored-by: Owen Edwards <owen.r.edwards@gmail.com> Co-authored-by: Steve Heffernan <git@heff.me>
Description
When an index is specified with
Component.addChild()then the new component's element is added at the given index. This isn't necessarily correct, as not all of a component's children have DOM elements. Adding a component at the index of the control bar in the player's children will insert its el after the control bar el, because of the MediaLoader and LiveTracker.Specific Changes proposed
When inserting the elelment, refer to the
el_of the sibling component this is to be inserted before.Requirements Checklist