Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo image link in documentation is broken. #6340

Closed
Ahmdrza opened this issue Nov 29, 2019 · 3 comments · Fixed by #6345
Closed

Logo image link in documentation is broken. #6340

Ahmdrza opened this issue Nov 29, 2019 · 3 comments · Fixed by #6345

Comments

@Ahmdrza
Copy link

Ahmdrza commented Nov 29, 2019

Description

Logo image link in documentation is broken.

Steps to reproduce

  1. Go to this link
  2. See at the logo in top left, image is broken.

Results

Expected

Actual logo should be displayed

Actual

No logo image is appearing due to broken link.

@welcome
Copy link

welcome bot commented Nov 29, 2019

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@IMHOJEONG
Copy link

How about using this way?

I added svg_link and filter:invert(1) in img tag.

test5

@gkatsev
Copy link
Member

gkatsev commented Dec 2, 2019

Haha, thanks. Probably shouldn't have linked directly to it and I forgot that we linked it when we updated our new website.
We do have a white logo in the website repo (https://github.com/videojs/videojs.com/blob/master/src/images/logo-white.svg). We probably should just copy it to this repo directly because that hash could change and break the logo again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants