Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: player.loadTech_ incorrect arrow function #7254

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

FredZeng
Copy link
Contributor

@FredZeng FredZeng commented May 31, 2021

Description

fullscreenchange, fullscreenerror events triggered by Html5 were not handled as expected by player since some arrow functions missing necessary argument.

Steps to reproduce

  1. calling player.requestFullscreen() on any iOS device
  2. runing code below to exit fullscreen
function exitfullscreen() {
    if (player.isFullscreen()) {
        player.exitFullscreen();
    }
}

Results

Expected

video can exit fullscreen

Actual

video cannot exit fullscreen

Reason

After entered fullscreen, player.isFullscreen() still remain false.

Specific Changes proposed

None.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@FredZeng
Copy link
Contributor Author

By the way, might better check L1218 as well.

this.on(this.tech_, 'textdata', (e) => this.handleTechTextData_(e));

@FredZeng FredZeng marked this pull request as draft June 2, 2021 12:10
@FredZeng FredZeng marked this pull request as ready for review June 2, 2021 12:11
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label Jun 2, 2021
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@misteroneill misteroneill removed the needs: LGTM Needs one or more additional approvals label Jun 2, 2021
@gkatsev gkatsev merged commit 41d5eb3 into videojs:main Jun 2, 2021
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants