fix: tight controlbar coupling (#7689) #7692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
requested changes
Mar 24, 2022
Done.. |
Codecov Report
@@ Coverage Diff @@
## main #7692 +/- ##
==========================================
+ Coverage 80.89% 80.91% +0.01%
==========================================
Files 116 116
Lines 7455 7455
Branches 1806 1807 +1
==========================================
+ Hits 6031 6032 +1
+ Misses 1424 1423 -1
Continue to review full report at Codecov.
|
misteroneill
previously requested changes
Mar 28, 2022
Co-authored-by: Pat O'Neill <pgoneill@gmail.com>
mister-ben
approved these changes
Mar 29, 2022
gkatsev
approved these changes
Mar 29, 2022
|
@misteroneill Excuse me, when to expect patch with this fix?) |
|
Congrats on merging your first pull request! 🎉🎉🎉 |
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
Fixes videojs#7689 Co-authored-by: alex <try2betheb3st@gmail.com> Co-authored-by: Pat O'Neill <pgoneill@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have tight coupling in player.js Class Player method resetControlBarUI_(), when using reset() method.
ControlBar component may be not exists or exists on another nesting level.
Fixes #7689
Specific Changes proposed
Added condition
Requirements Checklist