Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in player, techGet is undefined and should be techGet_ in handleTechSourceset_ method #8255

Closed
danrossi opened this issue Apr 30, 2023 · 1 comment · Fixed by #8256
Closed

Comments

@danrossi
Copy link

I had this error caught in a custom tech of mine.

const techSrc = this.techGet('currentSrc');

amtins added a commit to amtins/video.js that referenced this issue Apr 30, 2023
@amtins
Copy link
Contributor

amtins commented May 3, 2023

Hi @danrossi, can you provide a use case leading to this error? We at SRG SSR have developed our tech as well and I would like to assess the potential risks to know if we should mitigate it. 👍🏽

A naive approach would be to do something like:

player.techGet = function (e) {return this.techGet_(e)}

amtins added a commit to amtins/video.js that referenced this issue May 18, 2023
misteroneill pushed a commit that referenced this issue May 31, 2023
edirub pushed a commit to edirub/video.js that referenced this issue Jun 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants