Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.13.0] HTML-validation errors with the new version #8708

Closed
boris-petrov opened this issue Apr 24, 2024 · 0 comments · Fixed by #8711
Closed

[8.13.0] HTML-validation errors with the new version #8708

boris-petrov opened this issue Apr 24, 2024 · 0 comments · Fixed by #8711

Comments

@boris-petrov
Copy link
Contributor

boris-petrov commented Apr 24, 2024

Description

I upgraded video.js to 8.13.0 and my HTML validator started giving the following warnings:

Error: Duplicate ID “captions-background-vjs_video_826_component_1399”.
Error: The “aria-labelledby” attribute must point to an element in the same document.

Indeed in the document I see multiple:

<legend id="captions-background-vjs_video_826_component_1399">

And

<select id="vjs_select_1441" aria-labelledby="captions-background-vjs_video_826_component_1399 captions-background-color-vjs_video_826_component_1399">

Reduced test case

None

Steps to reproduce

Just add video.js to any page.

Errors

No response

What version of Video.js are you using?

8.13.0

Video.js plugins used.

No response

What browser(s) including version(s) does this occur with?

Chromium

What OS(es) and version(s) does this occur with?

Linux

cc @bzizmo, @wseymour15, @CarlosVillasenor

@boris-petrov boris-petrov added the needs: triage This issue needs to be reviewed label Apr 24, 2024
@mister-ben mister-ben removed the needs: triage This issue needs to be reviewed label Apr 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants