[8.14.1] Duplicate HTML IDs #8754
Labels
needs: triage
This issue needs to be reviewed
Comments
9 tasks
mister-ben
added a commit
that referenced
this issue
Jun 1, 2024
## Description Prevents a duplicate id in text track settings. Fixes #8754 ## Specific Changes proposed The text edge settings were erroneously duplicating the id generated for the background colour. Changes to a unique name. Adds a general test for duplicate ids. ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser (Chrome, Firefox, IE) - [x] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [x] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [x] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Upgrading from 8.12.0 to 8.14.1 fails my tests as there are duplicate IDs in the DOM. For example
captions-background-vjs_video_3_component_594. I see it once in<legend id="...">Text Background</legend>and once in<legend id="...">Text Edge Style</legend>. Let me know if that's not enough information.Reduced test case
N/A
Steps to reproduce
Just add
video.jsto a page.Errors
No response
What version of Video.js are you using?
8.14.1
Video.js plugins used.
No response
What browser(s) including version(s) does this occur with?
Chromium
What OS(es) and version(s) does this occur with?
Linux
P.S. I guess that similar to #8708.
The text was updated successfully, but these errors were encountered: