New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset player on source change. closes #1050 #1124

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@mmcc
Member

mmcc commented Mar 31, 2014

When the source of a video changes changes...

  • Remove first play event listener in case it was never fired the first time around.
  • Add a new first play event listener.
  • Remove .vjs-has-started
Show outdated Hide outdated src/js/player.js
/**
* Need to create this outside the scope of onLoadStart so it
* can be added and removed (to avoid piling first play listeners).
*/

This comment has been minimized.

@heff

heff Apr 1, 2014

Member

@mmcc can you add an @private tag after the description here? Otherwise this will get added to the docs. Either that or use a // comment.

@heff

heff Apr 1, 2014

Member

@mmcc can you add an @private tag after the description here? Otherwise this will get added to the docs. Either that or use a // comment.

This comment has been minimized.

@mmcc

mmcc Apr 2, 2014

Member

Who wouldn't want to see these comments in the docs?!

@mmcc

mmcc Apr 2, 2014

Member

Who wouldn't want to see these comments in the docs?!

@mmcc mmcc closed this in 95c29e6 Apr 3, 2014

@mmcc mmcc deleted the mmcc:feature/reset branch Apr 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment