Added a more informative and styled fallback message for non-html5 browsers #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owsers that also have JavaScript disabled
|
The support page for this had been added. |
|
merged in d96e008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...that also have JavaScript disabled
We often use a very simple fallback message like "Video Playback Not Supported" or just exclude the fallback message all together, but we should have something better there.
This only applies to browser that have no HTML5 video support AND javascript disabled. If javascript is enabled, video.js should still handle the video and show the appropriate no-support icon/message.
Some challenges here is that, without javascript, we can adjust the size of the paragraph to match what the video player would look like. In stead I created a 300x150px square with the message inside that centers itself. It's hard to say if that's the best approach across all use cases.
Also, @mmcc is working on the page on videojs.com that this message will point to.