New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a more informative and styled fallback message for non-html5 browsers #1181

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@heff
Member

heff commented Apr 29, 2014

...that also have JavaScript disabled

We often use a very simple fallback message like "Video Playback Not Supported" or just exclude the fallback message all together, but we should have something better there.

This only applies to browser that have no HTML5 video support AND javascript disabled. If javascript is enabled, video.js should still handle the video and show the appropriate no-support icon/message.

Some challenges here is that, without javascript, we can adjust the size of the paragraph to match what the video player would look like. In stead I created a 300x150px square with the message inside that centers itself. It's hard to say if that's the best approach across all use cases.

Also, @mmcc is working on the page on videojs.com that this message will point to.

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff May 5, 2014

Member

The support page for this had been added.
http://www.videojs.com/html5-video-support/

Member

heff commented May 5, 2014

The support page for this had been added.
http://www.videojs.com/html5-video-support/

@heff

This comment has been minimized.

Show comment
Hide comment
@heff

heff May 5, 2014

Member

merged in d96e008

Member

heff commented May 5, 2014

merged in d96e008

@heff heff closed this May 5, 2014

@heff heff deleted the heff:feature/no-js branch May 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment