Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track the object element during init and remove it if the tech is dispos... #1340

Merged
merged 2 commits into from Jul 28, 2014
Merged

Track the object element during init and remove it if the tech is dispos... #1340

merged 2 commits into from Jul 28, 2014

Commits on Jul 9, 2014

  1. Track the object element during init and remove it if the tech is dis… 

    …posed before onReady. For videojs#1339.

If dispose() was called before the SWF triggered onReady(), the placeholder div would be cleaned up but the actual object element would be left behind to mess things up in the future. Keep track of the object element during initialization and make sure it is removed if flash is unloaded early.
    @dmlap
    dmlap committed Jul 9, 2014
    Copy the full SHA
    da19fa3 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2014

  1. Set this.el_ directly instead of using another variable 

    The flash tech doesn't need to hold onto a reference to the placeholder element after the embed code has been generated. Set this.el_ to the embed code immediately instead of using another property to track it during init. Tested in IE8.
    @dmlap
    dmlap committed Jul 10, 2014
    Copy the full SHA
    a77e39f View commit details
    Browse the repository at this point in the history