Changed custom controls to be the default on touch devices (!) #1617
Conversation
| @@ -44,7 +44,8 @@ vjs.Html5 = vjs.MediaTechController.extend({ | |||
| // Our goal should be to get the custom controls on mobile solid everywhere | |||
| // so we can remove this all together. Right now this will block custom | |||
| // controls on touch enabled laptops like the Chrome Pixel | |||
| if (vjs.TOUCH_ENABLED && player.options()['nativeControlsForTouch'] !== false) { | |||
| if (vjs.TOUCH_ENABLED && player.options()['nativeControlsForTouch'] === true) { | |||
| alert('useNativeControls'); | |||
There was a problem hiding this comment.
alert? This doesn't seem right.
* 'stable' of https://github.com/videojs/video.js: (22 commits) Added line to changelog for 4.10.1 Release 4.10.1 Removed alert... Release 4.10.0 @heff turned on the custom html controls for touch devices. closes videojs#1617 updated options to include sans-children, and included self-hosted font blurb added CORS information to tracks guide. Fixes videojs#837 doc updates + readme quick start updated options guide to include components @heff Added the ability to set options for child components directly in the parent options. closes videojs#1599 @DevGavin added a Simplified Chinese translation. closes videojs#1593 @mmcc fixed an issue with the VolumeButton assuming it was vertical by default. closes videojs#1592 @heff enhanced the event listener API to allow for auto-cleanup of listeners on other componenets and elements. closes videojs#1588 @mmcc fixed an issue where errors on source tags could get missed. closes videojs#1575 Added doc for remaining time and removed onWaitEnd doc maybe actually check for keyLocation Update languages.md @heff updated the poster to use CSS styles to display; fixed the poster not showing if not originally set. closes videojs#1568 Release 4.9.1 Bumped to videojs-swf v4.5.1 to fix a data sanitization issue. closes videojs#1587 ...
|
And iOS still uses native controls on fullscreen, isn't it? |
|
@mente Yeah, there's no way to get around that unfortunately. |
|
I think it's worth mentioning somewhere in changelog or docs |
|
Which bit should be mentioned? Defaulting to native controls was mentioned in the changelog. We should probably add a note about how iOS handles fullscreen somewhere, though. |
|
I was talking about iOS fullscreen
|
Previously we've relied on native controls on touch devices, but now switching to use the video.js custom controls by default.
This can be reverted by setting the option
nativeControlsForTouch: true.I've tested across Android, iOS, and Windows 8.1 and it all works decently. There's a few things we could improve, like the size of the controls on touch devices, but better to get this out now than wait any longer.