Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bower install information #1840

Closed
wants to merge 2 commits into from
Closed

Conversation

kedar2a
Copy link
Contributor

@kedar2a kedar2a commented Jan 31, 2015

  • As videojs in present in bower and bower being popular static files manager now-a-days, it's information has been added.
  • Developers normally looks for bower install information to get the dependency as I was.
  • Hope it would be useful.

- As `videojs` in present in `bower` and bower being popular static files manager now-a-days, it's information has been added.
- Developers normally looks for bower install information to get the dependency as I was.
- Hope it would be useful.
@mmcc
Copy link
Member

mmcc commented Feb 1, 2015

Thank you for the PR! We're going to encourage folks to use NPM / Browserify, but obviously different strokes and such. My concern with starting to add specific instructions like this is our README is going to end up looking like our root directory, full of a billion different manifest files for different managers ( that's an exaggeration, but we do have: bower.json, package.json, component.json and composer.json).

That's a wall of text to say, I think we should have instructions for using our "blessed" way (which will eventually be NPM / Browserify), then mention that it's available on these other platforms. At most, instructions for other package managers should probably just be one liners (ish) to avoid clutter.

So, for now, would you mind updating the PR to look something like this:

## Install via package manager
### NPM
```
$ npm install --save video.js
```
### Bower
```
$ bower install --save video.js
```

@gkatsev
Copy link
Member

gkatsev commented Feb 1, 2015

There is no browserify install. It just uses npm.

@mmcc
Copy link
Member

mmcc commented Feb 1, 2015

that was me not being functional late in the second day of a conference (that was supposed to be bower, not browserify).

@gkatsev
Copy link
Member

gkatsev commented Feb 1, 2015

hehe, :D

@kedar2a
Copy link
Contributor Author

kedar2a commented Feb 2, 2015

Hey, thank you @mmcc for the good suggestion and to keep the text clean and simple.
Updated file accordingly with the commit.

@mmcc
Copy link
Member

mmcc commented Feb 10, 2015

lgtm

@mmcc mmcc closed this in 789c729 Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants