Improve localisation #1873
Closed
Improve localisation #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return languages[lang][string]; | ||
| } | ||
| var primaryCode = lang.split('-')[0]; |
There was a problem hiding this comment.
Though I think no one likes it at this point, most of the rest of the code declares variables at the top of the scope.
|
It sounds like there's still a little reworking to be done here, but the overall improvements sound good to me. |
|
+1! |
|
@mister-ben, available to finish this one up? Let me know if you have any additional questions. |
|
I've been a bit swamped with other things, but do intend to revisit this soon. |
|
Hey @mister-ben, still want to help finish this one up? |
|
Having another look now after getting it rebased. |
bower.json: Remove font files from `main`
Per bower/spec@a325da3 closes videojs#2144 bower.json: main: fix path to video.js bower.json: main: video-js.css => video-js.scss Per bower/spec#43 : > Use source files with module exports and imports over pre-built distribution files. Also, the example in that PR includes /sass/motion.scss in and excludes /dist/movement.css & /dist/movement.min.css from its `main`. bower.json: Set moduleType & use non-dist video.js Again, see bower/spec#43
Closed
|
Re-done as #2177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of improvements to localisation:
de-DEtranslation, usedeif available.en-usbut Chrome and Firefox useen-US, these should be treated the same.This should match how CSS applies styles based on lang attributes: http://jsbin.com/geviwa/edit