Set the duration display on 'ready' #2151
Conversation
|
Thanks Brandon, any more background on this one? Does it need to go out as a patch? We're trying to be relatively conservative with how much we patch 4.x because it slows down the 5.0 development. |
|
Code wise this looks good to me. |
|
Don't know what happened with the Savage test here. Hopefully the logs would be enlightening. |
|
Is it just stalled? @mmcc could you check it out? |
|
Using loadedmetadata as @heff suggested works just as well as using the ready event. I believe there is a customer waiting on this issue, so it should likely be patched. I'll submit another PR to bring it into master as well once we make a decision about whether this should be patched or not. |
|
@bc-bbay is there an equivalent patch against master for this issue? Can you link it here? |
|
No, #2150 was a mistake. I was waiting until we had the ok on this one before I duplicated the work in master, so I didn't have to make edits in two branches. I'll create that now. |
No description provided.